Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix documentation error (usage of noop setContentType) #6720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schmitch merged 1 commit into from
Nov 11, 2016
Merged

Fix documentation error (usage of noop setContentType) #6720

schmitch merged 1 commit into from
Nov 11, 2016

Conversation

@diamondo25
Copy link
Contributor

@diamondo25 diamondo25 commented Nov 10, 2016 •
edited
Loading

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #6707

Purpose

Fixes a documentation error that made people use the noop setContentType of play.mvc.Http.Response

Background Context

Cleaning up an issue that had no real priority but gave backlog.

References

#6707

@diamondo25
Fix documentation error (usage of noop setContentType)
f993468 
Fixes playframework#6707 (Documentation uses deprecated setContentType() method)
@schmitch schmitch merged commit 1996aa4 into playframework:master Nov 11, 2016
gmethvin pushed a commit that referenced this pull request Nov 12, 2016
@diamondo25 @gmethvin
Fix documentation error (usage of noop setContentType) (#6720)
eaaa068 
Fixes #6707 (Documentation uses deprecated setContentType() method)
@mkurz mkurz added this to the 2.5.10 milestone Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schmitch schmitch schmitch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.10

Development

Successfully merging this pull request may close these issues.

3 participants

@diamondo25 @schmitch @mkurz