Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you signed the Lightbend CLA?
• Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
• Have you added copyright headers to new files?
• Have you checked that both Scala and Java APIs are updated?
• Have you updated the documentation for both Scala and Java sections?
• Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #6792

Purpose

Adds dependency on play.db.DBApi to play.db.jpa.DefaultJPAApi.JPAApiProvider to ensure that data sources are initialised and bound to JNDI before they are accessed.

Background Context

The implementations of JPAApi and DBApi do not have any dependencies that would ensure the order in which they are both created, so there is no guarantee that the data source is bound to JNDI by HikariCPConnectionPool before it is accessed by DefaultJPAApi. By adding a dependency on play.db.DBApi to play.db.jpa.DefaultJPAApi.JPAApiProvider data sources are always initialised and bound to JNDI before they are accessed.

References