Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reference to play-redis module in Module directory in the documentation #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcospereira merged 1 commit into from
Jan 4, 2017
Merged

Reference to play-redis module in Module directory in the documentation #6850

marcospereira merged 1 commit into from
Jan 4, 2017

Conversation

@KarelCemus
Copy link
Contributor

@KarelCemus KarelCemus commented Jan 3, 2017

Purpose

This PR updates the documentation. It adds reference to play-redis module implementing a redis based cache. It implements common CacheAPI and some additional redis commands including the support of collections. The API is implemented in both blocking and asynchronous manner.

@KarelCemus
Copy link
Contributor Author

KarelCemus commented Jan 3, 2017

Please backport it also into 2.5.x, if you accept this PR

@marcospereira
Copy link
Member

marcospereira commented Jan 3, 2017

Hey @KarelCemus, thank you!

There is a "Datastore" section at this documentation page. It could be a better place to add this module. Nothing serious, but it could be easier to other user to find your plugin.

After that, this PR will be good to be merged and backported.

@KarelCemus
Copy link
Contributor Author

KarelCemus commented Jan 3, 2017

Hi, thanks, I know. I hesitated where to put it. It appended it just after

Memcached Plugin

Website: https://github.com/mumoshu/play2-memcached
Short description: Provides a memcached based cache implementation

which seemed appropriate. However, I'll move it among datastores.

@KarelCemus
Copy link
Contributor Author

KarelCemus commented Jan 4, 2017

Done, I fixed that.

@marcospereira marcospereira merged commit a146ff1 into playframework:master Jan 4, 2017
@KarelCemus
Copy link
Contributor Author

KarelCemus commented Jan 23, 2017

@marcospereira Today, I checked modules directory for version 2.5.x as there is new release and it seems that this PR has not been backported yet. Could you look at it, please?

marcospereira pushed a commit that referenced this pull request Jan 23, 2017
@KarelCemus @marcospereira
Reference to play-redis module in Module directory in the documentati…
ecda95c 
…on (#6850)
@marcospereira
Copy link
Member

marcospereira commented Jan 23, 2017

@KarelCemus backport here: ecda95c

The module will appears next time we publish the docs.

@KarelCemus
Copy link
Contributor Author

KarelCemus commented Jan 23, 2017

Thanks.

@mkurz mkurz added this to the 2.5.13 milestone Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marcospereira marcospereira marcospereira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.13

Development

Successfully merging this pull request may close these issues.

3 participants

@KarelCemus @marcospereira @mkurz