Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Deploying.md #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcospereira merged 1 commit into from
Jan 24, 2017
Merged

Update Deploying.md #6874

marcospereira merged 1 commit into from
Jan 24, 2017

Conversation

@Dinduks
Copy link
Contributor

@Dinduks Dinduks commented Jan 12, 2017 •
edited
Loading

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

@marcospereira
Copy link
Member

marcospereira commented Jan 24, 2017

Hello @Dinduks,

Thanks for contributing to Play. What is the purpose of this change?

@Dinduks
Copy link
Contributor Author

Dinduks commented Jan 24, 2017

Hi @marcospereira.

Java properties should be passed before the -jar jarname.jar part.
The syntax currently in the documentation is incorrect.

@marcospereira marcospereira merged commit fcf8319 into playframework:master Jan 24, 2017
@marcospereira
Copy link
Member

marcospereira commented Jan 24, 2017

Thanks @Dinduks.

marcospereira pushed a commit that referenced this pull request Jan 24, 2017
@Dinduks @marcospereira
Update Deploying.md (#6874)
42ce9d9
@marcospereira
Copy link
Member

marcospereira commented Jan 24, 2017

Backport here: 42ce9d9

@mkurz mkurz added this to the 2.5.13 milestone Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marcospereira marcospereira marcospereira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.13

Development

Successfully merging this pull request may close these issues.

3 participants

@Dinduks @marcospereira @mkurz