added httpcore dependency #6904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmethvin
pushed a commit
that referenced
this pull request
Jan 22, 2017
Member
|
Thanks! Just released a new version (2.5.12) that adds the dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After upgrading to 2.5.11 I was getting runtime exceptions when using a class from
"org.apache.httpcomponents" % "httpclient".httpclienthas a dependency onhttpcore, buthttpcoreis excluded byExclusionRule(organization = "org.apache.httpcomponents")I could fix this by adding it to my app dependencies, but maybe it's better to have this dependency in the framework.
Here is a forum user who also had this problem.
thanks
Simon