Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thomastoye
Copy link
Contributor

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Could not tag a docker image as the latest using docker:publish/docker:publishLocal due to old sbt-native-packager version. This a backport of #6924 on master.

Purpose

Updates sbt-native-packager to the latest stable version.

Background Context

I tried to use dockerUpdateLatest in Docker := true, but it was broken in the sbt-native-packager used in Play 2.5.12

References

#6924
https://github.com/sbt/sbt-native-packager/releases/tag/v1.1.5
https://github.com/sbt/sbt-native-packager/releases/tag/v1.1.3
sbt/sbt-native-packager#845
sbt/sbt-native-packager#818
sbt/sbt-native-packager#838

@thomastoye
Copy link
Contributor Author

Could someone restart the build? Seems like it timed out. On master, this passed Travis (#6924).

@marcospereira marcospereira merged commit 7d30090 into playframework:2.5.x Jan 30, 2017
@thomastoye
Copy link
Contributor Author

👍 Any ETA for 2.5.13?

@mkurz mkurz added this to the 2.5.13 milestone Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants