Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rohitkhatana
Copy link

@rohitkhatana rohitkhatana commented Mar 14, 2017

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

@lightbend-cla-validator

Hi @takirohit,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@rohitkhatana
Copy link
Author

I have signed the CLA.

@benmccann
Copy link
Contributor

benmccann commented Mar 14, 2017

Got an error:

[error] (Play-Akka-Http-Server-Experimental/:scripted) Failed tests:
[error] akka-http / play-akka-http-plugin
[error] akka-http / system-property
[error] (SBT-Fork-Run-Plugin/
:scripted) Failed tests:
[error] fork-run / dev-mode
[error] Total time: 990 s, completed Mar 14, 2017 6:35:15 PM

Closing and reopening to kick off a new build and see if that was just a fluke

@benmccann benmccann closed this Mar 14, 2017
@benmccann benmccann reopened this Mar 14, 2017
@benmccann benmccann merged commit c490f50 into playframework:2.5.x Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants