Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade logback dependency to fix 5 secs delays in unittests #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benmccann merged 1 commit into from
Apr 3, 2017
Merged

Upgrade logback dependency to fix 5 secs delays in unittests #7182

benmccann merged 1 commit into from
Apr 3, 2017

Conversation

@tarmath
Copy link

@tarmath tarmath commented Apr 3, 2017

Fixes Issue #7169

See details/discussion on the issue's page

@wsargent
Copy link
Member

wsargent commented Apr 3, 2017

That's not the latest logback -- it should be http://mvnrepository.com/artifact/ch.qos.logback/logback-classic/1.2.3

@tarmath
Copy link
Author

tarmath commented Apr 3, 2017 •
edited
Loading

looking at the logback page, it seems like 1.1.x and 1.2.x are different "series", as they call it.

I wasn't sure if it was appropriate to upgrade to it in 2.5.x...?

@tarmath
Copy link
Author

tarmath commented Apr 3, 2017

well, I updated to 1.2.3 and ran the tests. Only 2 are failing and they both are/seem unrelated:

[error] Failed: Total 579, Failed 2, Errors 0, Passed 575, Skipped 2, Pending 4
[error] Failed tests:
[error] 	play.it.http.NettyIdleTimeoutSpec
[error] 	play.it.http.AkkaIdleTimeoutSpec
[error] (Play-Integration-Test/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 436 s, completed Apr 2, 2017 9:35:29 PM

Both show:

Caused by: java.io.FileNotFoundException: ./conf/generated.keystore (No such file or directory)

[error]   x support a separate timeout for https
[error]    Expected: java.net.SocketException. Got: javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection? instead

So, I'll update logback as per your suggestion

@wsargent
Copy link
Member

wsargent commented Apr 3, 2017

@benmccann I think it's worth it in this case.

@benmccann benmccann merged commit d37d7c6 into playframework:2.5.x Apr 3, 2017
@marcospereira marcospereira added this to the 2.5.14 milestone Apr 4, 2017
@gmethvin gmethvin mentioned this pull request Apr 18, 2017
Closed
@tarmath tarmath deleted the fix-tests-5secs-delay branch May 7, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benmccann benmccann benmccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.14

Development

Successfully merging this pull request may close these issues.

5 participants

@tarmath @wsargent @benmccann @marcospereira @mpichette-apple