Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Line 85, changed "It" to "In" #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkurz merged 1 commit into from
May 10, 2017
Merged

Line 85, changed "It" to "In" #7321

mkurz merged 1 commit into from
May 10, 2017

Conversation

@danielobasi
Copy link

@danielobasi danielobasi commented May 10, 2017

There was an error in line 85 so I changed "It" to "In"

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

@danielobasi
Line 85, changed "It" to "In"
15e9fab 
There was an error in line 85 so I changed "It" to "In"
@lightbend-cla-validator
Copy link

lightbend-cla-validator commented May 10, 2017

Hi @danielobasi,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@danielobasi
Copy link
Author

danielobasi commented May 10, 2017

I've signed the CLA

mkurz
mkurz approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: https://www.lightbend.com/contribute/cla/check/danielobasi

@mkurz mkurz merged commit 9c1f428 into playframework:2.5.x May 10, 2017
@marcospereira marcospereira added this to the 2.5.15 milestone May 10, 2017
@marcospereira marcospereira mentioned this pull request May 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkurz mkurz mkurz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.15

Development

Successfully merging this pull request may close these issues.

4 participants

@danielobasi @lightbend-cla-validator @mkurz @marcospereira