-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update JavaActions.md #7915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update JavaActions.md #7915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing user to explore more HTTP Responses
| @[simple-action](code/javaguide/http/JavaActions.java) | ||
|
|
||
| An action returns a `play.mvc.Result` value, representing the HTTP response to send to the web client. In this example `ok` constructs a **200 OK** response containing a **text/plain** response body. | ||
| An action returns a `play.mvc.Result` value, representing the HTTP response to send to the web client. In this example `ok` constructs a **200 OK** response containing a **text/plain** response body.For more examples of HTTP response check out [HTTP Responses] (https://www.playframework.com/documentation/2.5.8/api/java/play/mvc/Results.html) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the 2.6.x docs referencing 2.5.8 javadocs. You should instead link to /api/java/play/mvc/Results.html. So you can rewrite it to:
For more examples of HTTP responses see [`play.mvc.Result` methods](/api/java/play/mvc/Results.html#method.summary).
Contributor
Author
|
Thanks for the info sir and I have made the changes as you suggested. |
marcospereira
pushed a commit
that referenced
this pull request
Nov 24, 2017
Allowing user to explore more HTTP Responses
Member
|
Forward port to master: 50a2068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing user to explore more HTTP Responses
Pull Request Checklist
Helpful things
Provides detailed description about various methods that can be used by user.
Minor fix
Purpose
It is done in order to provide user better understandibility
What does this PR do?
Provides description of various Result methods for the user.
Why did you take this approach?
To provide detailed information