Remove httpConfiguration from ServerResultUtils #8085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was unused. On top of that, it was reloading the HttpConfiguration more often than required. This could result in warnings about the use of deprecated config parameters such as `play.crypto.secret` on every connection.
Author
|
Attn: @gmethvin and @richdougherty It would be good if this could be backported to 2.6.x. |
richdougherty
approved these changes
Dec 11, 2017
Author
|
Backported in #8107. |
gmethvin
pushed a commit
that referenced
this pull request
Dec 19, 2017
This field was unused. On top of that, it was reloading the HttpConfiguration more often than required. This could result in warnings about the use of deprecated config parameters such as `play.crypto.secret` on every connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was unused. On top of that, it was reloading the HttpConfiguration more often than required. This could result in warnings about the use of deprecated config parameters such as
play.crypto.secreton every connection.