Use Akka's Reason when shutting down and disable Akka JVM hooks globally #8087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmm, build fails on The fix for that issue is on #8088 |
Member
Member
Author
|
Thanks @marcospereira! I've updated the PR description: there's nothing left for this PR. We can relaunch the build and merge if it passes. |
Member
Author
|
Meh, it now failed on mima. I'll rebase on |
35400a5 to
3e66647
Compare
gmethvin
reviewed
Dec 18, 2017
|
|
||
| import javax.inject.{ Inject, Provider, Singleton } | ||
|
|
||
| import akka.actor.CoordinatedShutdown.ClusterDowningReason |
| } finally { | ||
| CoordinatedShutdown(actorSystem).run() | ||
| // On testing, use any reason | ||
| CoordinatedShutdown(actorSystem).run(JvmExitReason) |
Member
There was a problem hiding this comment.
It probably doesn't matter for now but since we're not actually killing the jvm it would make more sense to use ApplicationShutdownReason. Not sure if there is or could be special handling for the jvm exit case.
There was a problem hiding this comment.
Should it just invoke the returned stopHook?
gmethvin
pushed a commit
to gmethvin/playframework
that referenced
this pull request
Dec 19, 2017
…lly (playframework#8087) * Use Akka's Reason when shutting down and disable Artery * Organize imports of Akka.scala * Run the stopHook after ActorSystemProviderSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Akka
2.5.8introduced theReasonargument on theCoordinatedShutdownAPI so CS users can distinguish the actual trigger of the shutdown process.Akka
2.5.8also introduced thejvm-shutdown-hookssetting to make sure there's a single responsible for registering JVM shutdown hooks. This setting should be disabled on Play's2.6.xbranch.Play users that embed an Akka Cluster node inside the play application and use Artery will have to register the Artery shutdown manually. This need documentation.Artery is shutdown when the actor system is terminated which play will take care of.