Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Send errors from filters to the application HttpErrorHandler #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmethvin merged 1 commit into from
Dec 13, 2017
Merged

Send errors from filters to the application HttpErrorHandler #8091

gmethvin merged 1 commit into from
Dec 13, 2017

Conversation

@gmethvin
Copy link
Member

@gmethvin gmethvin commented Dec 12, 2017

Fixes #8089

This refactors the request handling code in the AkkaHttpServer and NettyServer slightly, so that the action is always executed in a future using the Play default execution context, then that future is flatMapped with a function that runs the body accumulator, and the resulting future is recovered using the error handler.

I added a test that tests with both the Filter and EssentialFilter case.

@gmethvin gmethvin force-pushed the filter-error-handler branch 2 times, most recently from a48add9 to 3b56952 Compare December 12, 2017 06:22
schmitch
schmitch reviewed Dec 12, 2017
View reviewed changes
framework/build.sbt Outdated
lazy val PlayFramework = Project("Play-Framework", file("."))
.enablePlugins(PlayRootProject)
.enablePlugins(PlayWhitesourcePlugin)
//.enablePlugins(PlayWhitesourcePlugin)
Copy link
Contributor

@schmitch schmitch Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you run into the same error as me, actually what helped is just remove all target folders or checkout the source code again.

Copy link
Member

@marcospereira marcospereira Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same happened to me once. Confirming that removing all target folders resolve the problem.

Copy link
Member Author

@gmethvin gmethvin Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this. I just ran into the error and didn't have time to figure it out.

@schmitch
Copy link
Contributor

schmitch commented Dec 12, 2017 •
edited
Loading

does this have a performance impact?

@gmethvin gmethvin force-pushed the filter-error-handler branch from 3b56952 to 1702333 Compare December 12, 2017 20:52
@gmethvin
Copy link
Member Author

gmethvin commented Dec 13, 2017

Okay so I ran Play-Microbenchmark/jmh:run -i 5 -wi 5 -f1 -t4 play.microbenchmark.it.HelloWorldBenchmark

Before:

[info] Benchmark                       (endpoint)  (reqsPerConn)   Mode  Cnt      Score      Error  Units
[info] HelloWorldBenchmark.helloWorld   nt-11-pln              5  thrpt    5  24407.809 ± 3284.289  ops/s
[info] HelloWorldBenchmark.helloWorld   nt-11-enc              5  thrpt    5  24058.859 ± 9721.483  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-11-pln              5  thrpt    5  20829.463 ± 9841.523  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-11-enc              5  thrpt    5  14978.026 ± 2929.331  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-20-enc              5  thrpt    5   8906.489 ± 5659.373  ops/s

After:

[info] Benchmark                       (endpoint)  (reqsPerConn)   Mode  Cnt      Score      Error  Units
[info] HelloWorldBenchmark.helloWorld   nt-11-pln              5  thrpt    5  24209.883 ± 4650.606  ops/s
[info] HelloWorldBenchmark.helloWorld   nt-11-enc              5  thrpt    5  22155.185 ± 9727.310  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-11-pln              5  thrpt    5  19364.448 ± 6954.653  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-11-enc              5  thrpt    5  14367.340 ± 7419.241  ops/s
[info] HelloWorldBenchmark.helloWorld   ak-20-enc              5  thrpt    5   8522.170 ± 2350.906  ops/s

It seems like it may have slowed things down very slightly but it's hard to tell.

@schmitch
Copy link
Contributor

schmitch commented Dec 13, 2017

well I would say this is fine. it's still in the derivation.

richdougherty
richdougherty reviewed Dec 13, 2017
View reviewed changes
framework/src/play-integration-test/src/test/scala/play/it/http/HttpFiltersSpec.scala Outdated

trait HttpFiltersSpec extends PlaySpecification with ServerIntegrationSpecification {

sequential
Copy link
Member

@richdougherty richdougherty Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, with new integration tests you can use the new "endpoint" integration test style which (a) avoids global state so we can do parallel testing and (b) has tests for HTTPS and HTTP/2.

Copy link
Member Author

@gmethvin gmethvin Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I moved to the new endpoint integration style.

richdougherty
richdougherty reviewed Dec 13, 2017
View reviewed changes
framework/src/play-akka-http-server/src/main/scala/play/core/server/AkkaHttpServer.scala
}

@deprecated("This method is an internal API and should not be public", "2.6.10")
def executeAction(
Copy link
Member

@richdougherty richdougherty Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it makes sense to deprecate this.

@richdougherty richdougherty mentioned this pull request Dec 13, 2017
Open
@gmethvin gmethvin force-pushed the filter-error-handler branch from 1702333 to 8b11f76 Compare December 13, 2017 21:36
@gmethvin gmethvin force-pushed the filter-error-handler branch from 8b11f76 to ed35af6 Compare December 13, 2017 21:38
@gmethvin gmethvin merged commit 033cf45 into playframework:master Dec 13, 2017
gmethvin added a commit that referenced this pull request Dec 13, 2017
@gmethvin
Send errors from filters to the application HttpErrorHandler (#8091)
3d784e9
@gmethvin gmethvin deleted the filter-error-handler branch December 13, 2017 23:06
@gmethvin
Copy link
Member Author

gmethvin commented Dec 13, 2017

backport to 2.6.x: 3d784e9

@marcospereira marcospereira added this to the Play 2.6.10 milestone Dec 21, 2017
@marcospereira marcospereira mentioned this pull request Feb 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@marcospereira marcospereira marcospereira left review comments

@richdougherty richdougherty richdougherty approved these changes

@schmitch schmitch schmitch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Play 2.6.10

Development

Successfully merging this pull request may close these issues.

4 participants

@gmethvin @schmitch @marcospereira @richdougherty