[2.6.x]: Make InlineCache use a soft (not weak) reference #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2017 12:17
Objects that are referenced only by a weak reference will be eagerly collected on the next GC run. Using a soft reference ensures that the referent is only collected when there is memory pressure. This should improve the utilization of the cache and reduce the need to repopulate it. See discussion in https://stackoverflow.com/a/299702/29470 for example.
This variable should have been private in the first place. The class is private[play] so it should be safe to break binary compatibility.
TimMoore
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #8086 to the 2.6.x branch. cc @TimMoore