fix Results class name in the doc #8119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to `play.mvc.Results` class methods is correct, but its name in the text is `play.mvc.Result`, which is not correct. This can be misleading since there's a different class named `play.mvc.Result` with its own methods.
|
Hi @scadgek, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
mkurz
pushed a commit
that referenced
this pull request
Jul 6, 2018
The link to `play.mvc.Results` class methods is correct, but its name in the text is `play.mvc.Result`, which is not correct. This can be misleading since there's a different class named `play.mvc.Result` with its own methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to
play.mvc.Resultsclass methods is correct, but its name in the text isplay.mvc.Result, which is not correct. This can be misleading since there's a different class namedplay.mvc.Resultwith its own methods.