add play.api.Configuration#load to the public API
#8138
Conversation
Allows for clients which don't require a configuration to be defined.
| directSettings: Map[String, AnyRef], | ||
| allowMissingApplicationConf: Boolean): Configuration = { | ||
| def load(classLoader: ClassLoader, properties: Properties, directSettings: Map[String, AnyRef], | ||
| allowMissingApplicationConf: Boolean): Configuration = { |
There was a problem hiding this comment.
@erip The build is broken because of scalariform formatting.
Scalariform wants it to be formatted as:
def load(classLoader: ClassLoader, properties: Properties, directSettings: Map[String, AnyRef],
allowMissingApplicationConf: Boolean): ConfigurationI also prefer formatting aligned with the first opening parenthesis, but between what Scalariform is requiring and the previous format, I think it's preferable to have all arguments aligned on the same column.
The advantage of column alignment is that the human eyes can parse a break-line much easier than a comma. So we can easily distinguish all the arguments and we don't need to parse the line for commas.
My 2cc. :-)
|
@renatocaval thanks for checking. I commited and went to sleep so I didn't see the failure until this morning. 😅 Because these commits are small, I've just been doing them from github's ui... Will the commits be squashed automatically? |
|
yes, they will be squashed. However, I'm not sure it will pass scalariform. I think you can't align using the open parenthesis. Maybe I was not clear about it. I do prefer to align it on the parenthesis, but scalariform puts on the next line with indentation 2. |
|
You can cherrypick the latest commit if you want this PR... only thing that changes is indentation between all commits. |
* add `play.api.Configuration#load` to the public API Allows for clients which don't require a configuration to be defined. * fixes style * fix style * fix style
|
I backported this to 2.6.x: ff2df6b |
|
Thanks so much, @gmethvin. 👍 |
In Lagom, clients require an
application.conflest an exception be thrown.To mitigate this, passing
allowMissingApplicationConftoConfiguration#loadwould be perfect. Unfortunately, it is only part of the private API.This PR adds
Configuration#load(withallowMissingApplicationConf) to the public API.