logback graceful shutdown #8407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @YuitoSato, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Contributor
Author
|
done with signing the CLA. |
…/playframework into 8277_logback_graceful_shutdown
wsargent
suggested changes
May 14, 2018
| * These default configs specify only a console logger which outputs only 10 lines of an exception stack trace. | ||
| * Play uses ANSI color codes by default in level messages. | ||
| * For production, the default config puts the console logger behind the logback [AsyncAppender](https://logback.qos.ch/manual/appenders.html#AsyncAppender). For details on the performance implications on this, see this [blog post](https://blog.takipi.com/how-to-instantly-improve-your-java-logging-with-7-logback-tweaks/). | ||
| * In order to guarantee that logged messages have had a chance to be processed by asynchronous appenders (including the TCP appender) and ensure background threads have been stopped, you'll need to cleanly shut down logback when your application exits. |
Member
There was a problem hiding this comment.
This is good, but we want to have the line explicitly included:
<shutdownHook class="ch.qos.logback.core.hook.DelayingShutdownHook"/>
along with a link to https://logback.qos.ch/manual/configuration.html#shutdownHook and https://jira.qos.ch/browse/LOGBACK-1090
Contributor
Author
|
Thanks @wsargent. |
wsargent
approved these changes
Jun 14, 2018
Kavit900
added a commit
to Kavit900/playframework
that referenced
this pull request
Jun 14, 2018
* remove apache commons libs (playframework#8455) * remove apache commons libs currently play added a lot of "helper" libraries in the past, however with recent JVM upgrades and more and more stuff inside the JVM itself these got more and more unnecessary. Actually this imports some Classes from apache commons lang3, however only a really small subset of the library is imported. The subset itself barly changed over the recent years and Play mostly used just the reflect stuff of commons lang3 * Remove set current app when allow global false (playframework#8462) * Remove imports to current app * Add missing deprecation notes * Remove invalid scaladoc tags There is no `@deprecated` tag in scaladocs since we have the `@deprecated` annotation. * Do not set current app when global state is disabled * Configure mima filter * Clear warn messages when using global state * Just stop the current app if global state is enabled * logback graceful shutdown (playframework#8407) * add shutdown hook to logback-play-default.xml playframework#8277 * update SettingsLogger.md documentation playframework#8277 * delete an unnecessary line playframework#8277. * add shutdown hook to logback-play-logSql.xml playframework#8277 * add line playframework#8277 * update SettingsLogger.md playframework#8277 * update SettingsLogger.md playframework#8277
Member
|
2.6.x: 3aa4930 |
Member
|
Starting with Play 2.7, adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #8277
Purpose
This PR adds graceful shutdown setting to the default logback which uses AsyncAppender.