Fix issues when building on Windows #8495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jul 1, 2018
| @@ -110,8 +107,7 @@ public Function<Multipart.FileInfo, Accumulator<ByteString, FilePart<File>>> cre | |||
| private File generateTempFile() { | |||
| try { | |||
| final EnumSet<PosixFilePermission> attrs = EnumSet.of(OWNER_READ, OWNER_WRITE); | |||
benmccann
approved these changes
Jul 7, 2018
marcospereira
added a commit
that referenced
this pull request
Jul 16, 2018
* Fix issues when building on Windows * Remove unused code
Member
Author
|
2.6.x: 65812ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #8449.
Purpose
Make it possible to build Play on Windows without changing any project configurations. This was tested on a Windows 10 VM.