[2.6.x]: Added Java APIs for general dependency-injection to be DI framework agnostic #8586
Conversation
|
Hey @marcospereira is there anything else need to be addressed for checking in? Thanks! |
marcospereira
left a comment
There was a problem hiding this comment.
LGTM.
Thank you, @FranklinYinanDing.
I think as soon as we get a green build it will be okay to merge.
|
@marcospereira Thanks for reviewing! I've corrected the real errors buried by other false positive ones, and verified locally. But I noticed that the CI job wasn't kicked off by my commit. Is there something wrong with the CI build? |
|
NVM! Maybe just some delay. All green now! |
marcospereira
left a comment
There was a problem hiding this comment.
Small comment and after that let's merge it. :-)
Thanks, @FranklinYinanDing.
| import com.google.inject.{ CreationException, ProvisionException } | ||
| import com.typesafe.config.Config | ||
| import org.specs2.mutable.Specification | ||
| import play.{ Environment => EnvironmentJ } |
There was a problem hiding this comment.
Nitpicks: noticed this while I was reviewing the other PR. Let's use Something => JavaSomething instead of Something => SomethingJ. :-)
There was a problem hiding this comment.
Done! That was our internal naming convention. I'll keep this in mind for future PR.
|
@marcospereira Could you please take a look at the latest CI failure? I don't think my change causes this. Thank you! |
|
@FranklinYinanDing I've triggered the job again. It may be a problem with Travis cache. |
|
Not sure if the latest one is the one you triggered, (the time looks like it), but it is still failing :( |
|
We got a green build after cleaning Travis cache. :-) |
marcospereira
left a comment
There was a problem hiding this comment.
👍
Thanks for your patience here, @FranklinYinanDing.
|
Thank you for reviewing! I'll start working on the master branch one. |
|
@FranklinYinanDing this is part of Play 2.6.20 released just a few hours ago. :-) |
|
Great! Thank you! I'm picking it up right now. @marcospereira |
…gnostic
Backport #8559 to
2.6.xbranch.