Fix PhantomReference approach for TempFileCreator. #8614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject preventing GC from triggering finalizeReferent of phantom reference)
marcospereira
approved these changes
Sep 18, 2018
Member
marcospereira
left a comment
There was a problem hiding this comment.
LGTM. Good and subtle fix. :-)
Thank you, @alexandrtarasyuk. Let's just wait for a green build.
marcospereira
pushed a commit
that referenced
this pull request
Sep 18, 2018
…bject preventing GC from triggering finalizeReferent of phantom reference) (#8614)
Member
|
Backport to 2.6.x: f9c05f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Should fix problem with TempFile objects not being released in memory (including proper deletion of underlining file).
Purpose
Remove tempFile from closure (to avoid strong reference to tempFile object preventing GC from triggering finalizeReferent of phantom reference).
As a result finalizeReferent method with deletePath is proper called when GC collects TempFile after usage.
Background Context
This issue was found as a result of memory leak investigation (all TempFile objects created are held in memory while play application is alive).
References
N/A