Cleanup JPA api so we can remove Http.Context #8616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2018
Member
Author
|
Question about following error: I did remove the |
Member
Author
|
Seems there is no way, I just removed the link like other did before for other links. |
Member
marcospereira
left a comment
There was a problem hiding this comment.
LGTM.
I think we only need to add an explanation on our migration guide.
Member
Yeah, all the docs are built together. Anyway, removing the link does not look like an issue to me. |
octonato
pushed a commit
that referenced
this pull request
Sep 20, 2018
Member
Author
|
Done 👍 Added note to migration guide. |
marcospereira
approved these changes
Sep 20, 2018
Member
marcospereira
left a comment
There was a problem hiding this comment.
LGTM.
Thank you, @mkurz.
|
|
||
| ## JPA removals and deprecations | ||
|
|
||
| The class `play.db.jpa.JPA`, which has been deprecated in Play 2.6 already, has finally been removed. Have a look at the [[Play 2.6 JPA Migration notes|JPAMigration26]] if you haven't yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing per commit should be easiest.
The class
play.db.jpa.JPAwas deprecated in 2.6 already, lets remove it.I deprecated more methods which relied on the
JPAEntityManagerContextThreadLocal (so we can remove that in future as well). In futureJPAApionly haswithTransaction(...)left withFunctions orConsumers which always provide theEntityManager.@Transactionalshould have been deprecated in 2.6 already - it was removed from the docs and is now replaced by injecting aJPAApi.