Update heroku deploying docs (declaring java version) #8637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tried to rewrite the docs in more generic form without using java version numbers in text except properties example. I guess it can be backported to 2.6 branch too. Maybe its better to wait until #8628 PR will be finished and merged. |
mkurz
approved these changes
Sep 27, 2018
Member
|
Backport to 2.6.x: 23749da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR updates outdated fragment of heroku deployment documentations. After the java 11 LTS was released, there are not many reasons for using java 9/10(which are end-of-premier-support now) in both new and existing projects, especially since migration to java 11 is trivial. However, if someone needs to use java 9 or 10 for some reasons, the link to heroku documentation can help.