Lookup form helpers' _label and _name attributes in messages #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcospereira
left a comment
There was a problem hiding this comment.
Nice.
Small addition, but can we have a test for that?
Member
Author
|
Test added. |
marcospereira
pushed a commit
that referenced
this pull request
Oct 4, 2018
* Lookup form helpers' _label and _name attributes in messages * Add test
Member
|
Backport to 2.6.x: 0f783da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually I thought that was happening already - like it's done for the
getOrElsepart as well, however it looks like I forgot that when I added thetranslateMsgArgmethod and other i18n stuff to the helpers.(Actually I don't use the Play built-in helpers myself, most of the time play-bootstrap - which does look up these attributes in the messages - therefore I did not recognize earlier).
We can backport as well.