Revert "First set of changes to remove "download" terminology (#192)" #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amework#192)" This reverts commit 2688fcb.
Member
|
the change is rather big and I'm not too familiar with the codebase at hand. Did a quick read and it LGTM I guess. |
Member
|
Closing this after merging #206. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2688fcb.
This revert is not straightforward and therefore we need an extra pair of eyes reviewing it.
The deployment server gets an error when we try to update it because this was directly reverted there and it's now conflicting.
After merging this, one will need to do a hard reset of the last commit on the server and refresh the branch. I can do it.