Cookie expire date can be integer or float#67
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ec0e5cd to
dfcc5f3
Compare
Refactor cookie validation into internal class to reduce duplication
dfcc5f3 to
44f3ff4
Compare
|
@smnandre Do you think this is overkill, or do you need more time to have a deeper look? Sorry if I sound harsh ;) |
|
Please.... a contributor helping an OSS project... speak the way you want, this will never be harsh to me :) |
|
Yeah I wanted to test it locally, and was busy working on the Symfony bundle this week-end ... I'm gonna look later tonight if that's ok for you ? |
|
Thank you very much @stloyd ! tried to reach you on X... you can contact me on slack or email if you want! Anyway, thnk you very very much |
|
I have limited visibility for messages from not followers, but I have same nick on Symfony slack if needed to reach me faster 😉 |
Refactor cookie validation into internal class to reduce duplication