Align Page getBy* locators with Playwrights JS API#76
Open
braydend wants to merge 9 commits intoplaywright-php:mainfrom
Open
Align Page getBy* locators with Playwrights JS API#76braydend wants to merge 9 commits intoplaywright-php:mainfrom
braydend wants to merge 9 commits intoplaywright-php:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
braydend
commented
Mar 3, 2026
|
|
||
| $this->assertStringContainsString('/page2.html', $this->page->url()); | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
I moved these to the new test file. @smnandre Please advise if these should live somewhere else.
My intention is to keep that test file as the source of truth against the Playwright JS API
42a8931 to
3b50823
Compare
locators and toggling with 'exact' option
3b50823 to
1f2cecc
Compare
1f2cecc to
6ecd3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the Page Locator API to align it closer to the Playwright JS API
PagePlaywrightApiTestintegration test suite to test that the getBy* selectors align with the Playwright API