David/GitHub action update cdn #389
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayjayt
reviewed
Aug 18, 2025
There was a problem hiding this comment.
non-zero or zero exit, it matters:
if sys.exit(0), the action is marked as success.
if sys.exit(1), the action is marked as a failure.
When should it marked as failure? When as success?
Should be marked as failure when the user needs to be notified as something.
Careful with the prints. It would be nice if w/ action success/failure status, the subtitle was whatever link the user had to follow. This is what github pages does when a new pages is published.
Can this also automatically update the CHANGELOG is a second commit?
ayjayt
reviewed
Aug 30, 2025
| if brc_eval: | ||
| msg = err.decode() | ||
| if "HTTP 404" not in msg: | ||
| print(msg) # unexpected errors |
| ["gh", "api", f"repos/{REPO}/branches/{branch}", "--silent"] | ||
| ) | ||
|
|
||
| if brc_eval: |
There was a problem hiding this comment.
condicional un poco enredado
| print(msg) # unexpected errors | ||
| sys.exit(1) | ||
| else: | ||
| print(f"The branch {branch} already exists") |
| issues = json.loads(brc.decode()) | ||
| if issues: | ||
| for issue in issues: | ||
| if issue.get("state") == "OPEN": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatic update of plotly.js