Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Ability to supply figure without data #223

Closed
chriddyp opened this issue Jul 2, 2018 · 3 comments
Closed

Ability to supply figure without data #223

chriddyp opened this issue Jul 2, 2018 · 3 comments
Assignees
Labels
dash-type-bug Something isn't working as intended

Comments

@chriddyp
Copy link
Member

chriddyp commented Jul 2, 2018

v0.22.1 introduced a bug:

+            if (intersection(
+                pluck('type', figure.data),
+                ['candlestick', 'ohlc']).length
+            ) {
+                PlotMethod = Plotly.newPlot;
+            } else {
+                PlotMethod = Plotly.react;
+            }

now, if figure.data is undefined, the pluck('type', figure.data) fails. I believe that we should be able to fix this with just a R.has('data', figure) check. We should add some tests that supply figure as None, {}, {'layout': {}}, and {'data': []}

@chriddyp chriddyp added the dash-type-bug Something isn't working as intended label Jul 2, 2018
@chriddyp
Copy link
Member Author

chriddyp commented Jul 2, 2018

Originally reported here: https://community.plot.ly/t/error-loading-layout-after-core-components-0-22-1-and-ngrok/10350/5. We should loop back in that forum post when we get out a fix

@chriddyp
Copy link
Member Author

chriddyp commented Jul 2, 2018

@valentijnnieman - Could you grab this one this week? I've seen a few users report this issue in the forum, seems like it'd be an easy win 😸

@valentijnnieman valentijnnieman self-assigned this Jul 2, 2018
valentijnnieman added a commit that referenced this issue Jul 2, 2018
This fixes the bug described in #223
@rmarren1
Copy link
Contributor

Same as this: #260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants