HTML to ipynb update - matplotlib/colormaps #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcdunbar @cldougl the document has been fixed. Here is the notebook_demo: https://plot.ly/~notebook_demo/228/. Also please refer #1033 |
jdamiba
suggested changes
Aug 24, 2018
| </div> | ||
| <div class="inner_cell"> | ||
| <div class="text_cell_render border-box-sizing rendered_html"> | ||
| <h3 id="Colorbar-Custom-Size-and-TIcks">Colorbar Custom Size and TIcks<a class="anchor-link" href="#Colorbar-Custom-Size-and-TIcks">¶</a></h3> |
bcdunbar
reviewed
Aug 27, 2018
| "import plotly.graph_objs as go\n", | ||
| "import plotly.tools as tls\n", | ||
| "# Learn about API authentication here: https://plot.ly/python/getting-started\n", | ||
| "# Find your api_key here: https://plot.ly/settings/api\n", |
There was a problem hiding this comment.
I wrote this in the other PR but I'll paste it here too.
# Learn about API authentication here: https://plot.ly/python/getting-started
# Find your api_key here: https://plot.ly/settings/api
Looking at it again, I don't think that we require these commented lines anymore. They seem redundant given that this information is contained in the New to Plotly? section.
bcdunbar
reviewed
Aug 29, 2018
| "metadata": {}, | ||
| "source": [ | ||
| "See [https://plot.ly/python/reference/#layout-xaxis-rangeslider](https://plot.ly/python/reference/#layout-xaxis-rangeslider) and\n", | ||
| "[https://plot.ly/python/reference/#layout-xaxis-rangeselector](https://plot.ly/python/reference/#layout-xaxis-rangeselector) for more information and chart attribute options!" |
There was a problem hiding this comment.
I'm not sure that the references are relevant to this doc. Perhaps, just make this one something like:
#### Reference
See https://plot.ly/python/reference/ for more information and chart attribute options!
|
Almost there 😄 One last minor update to the reference section and then you can 💃 |
|
looks good 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for colors and colormaps #802