-
-
Notifications
You must be signed in to change notification settings - Fork 544
HTML to ipynb for histograms and heatmaps #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML to ipynb for histograms and heatmaps #1049
Conversation
Everything looks good. 💃 Documenting the first iteration of my code review workflow in this repo. Feedback welcome @cldougl @nicolaskruchten @bcdunbar
|
"import numpy\n", | ||
"import matplotlib.pyplot as plt\n", | ||
"import plotly.plotly as py\n", | ||
"import plotly.tools as tls\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example,
import plotly.plotly as py
import plotly.tools as tls
import matplotlib.pyplot as plt
import numpy as np
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"#### Multiple datasets\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize 😄 "Multiple datasets" > "Multiple Datasets"
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"#### Plot two histograms together\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Capitalize. "Plot Two Histograms Together"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I forgot to update this PR as well
Thanks for making the changes 💃 |
Update for histograms and heatmaps #802