Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTML to ipynb for histograms and heatmaps #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

priyatharsan
Copy link
Contributor

Update for histograms and heatmaps #802

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Aug 23, 2018
@jdamiba
Copy link
Contributor

jdamiba commented Aug 23, 2018

Everything looks good. 💃

Documenting the first iteration of my code review workflow in this repo. Feedback welcome @cldougl @nicolaskruchten @bcdunbar

  1. Launch the notebooks interactively at https://plot.ly/~notebook_demo/251 and https://plot.ly/~notebook_demo/250. Perform a visual inspection for alignment, grammar, and structure.

  2. Clone the feature branch. Ensure that bundle exec jekyll serve --config _config_dev.yml executes without error locally.

  3. Ensure that the code changes are clear and follow the principles outlined in https://github.com/plotly/dev-docs/blob/master/basics/code-review-checklist.md.

"import numpy\n",
"import matplotlib.pyplot as plt\n",
"import plotly.plotly as py\n",
"import plotly.tools as tls\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise in this PR, you'll want to #1048 (comment) in all the notebooks. Also, ensure that it is the same way @cldougl had it i.e. "plotly packages first then a space then additional packages "

Copy link
Contributor

@bcdunbar bcdunbar Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example,

import plotly.plotly as py
import plotly.tools as tls

import matplotlib.pyplot as plt
import numpy as np

"cell_type": "markdown",
"metadata": {},
"source": [
"#### Multiple datasets\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize 😄 "Multiple datasets" > "Multiple Datasets"

"cell_type": "markdown",
"metadata": {},
"source": [
"#### Plot two histograms together\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Capitalize. "Plot Two Histograms Together"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I forgot to update this PR as well

@bcdunbar
Copy link
Contributor

Thanks for making the changes 💃

@priyatharsan priyatharsan merged commit 3397d7c into source-design-merge Aug 29, 2018
@priyatharsan priyatharsan deleted the matplotlb-histogram-heatmap-doc-update branch August 29, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReviewReady This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants