Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Custom Binning tut for histogram doc #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

priyatharsan
Copy link
Contributor

Ref #1052

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Aug 29, 2018
"metadata": {},
"source": [
"### Custom Binning\n",
"For custom binning along x-axis, use the attribute [`nbinsx`](https://plot.ly/python/reference/#histogram-nbinsx). Please note that no matter how many bins being specified, the autobin algorithm will still give a 'nice' round bin sizes and edges. Alternatively, you can set the exact values for [`xbins`](https://plot.ly/python/reference/#histogram-xbins) along with `autobinx = False`."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Please note that the autobin algorithm will choose a 'nice' round bin size that may result in somewhat fewer than nbinsx total bins."

@@ -219,13 +219,13 @@ <h3 id="Horizontal-Histogram">Horizontal Histogram<a class="anchor-link" href="#
</div>
<div class="inner_cell">
<div class="text_cell_render border-box-sizing rendered_html">
<h3 id="Overlaid-Histgram">Overlaid Histgram<a class="anchor-link" href="#Overlaid-Histgram">&#194;&#182;</a></h3>
<h3 id="Overlaid-Histgram">Overlaid Histgram<a class="anchor-link" href="#Overlaid-Histgram">&#182;</a></h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new here, but... Histogram

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just those two minor comments then I'm happy.




<div class="output_html rendered_html output_subarea output_execute_result">
<iframe id="igraph" scrolling="no" style="border:none;" seamless="seamless" src="https://plot.ly/~PythonPlotBot/192.embed" height="525px" width="100%"></iframe>
<iframe id="igraph" scrolling="no" style="border:none;" seamless="seamless" src="https://plot.ly/~priyatharsan/813.embed" height="525px" width="100%"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be under the PythonPlotBot account? That way they don't get throttled etc?

Copy link
Contributor Author

@priyatharsan priyatharsan Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized recently that the embed link is generated automatically based on the plot being created when running the notebook. Since I have my account credentials synced to my windows the plot gets saved in my plotly account and I noticed this in many new notebooks as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriddyp would you like me to switch to PythonPlotBot and save the plot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that would be a good idea. Correct me if I'm wrong @cldougl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for using user: PythonPlotBot. Probably not necessary for throttling, however it's helpful for general management of these plots/to better ensure that they are not accidentally made private/deleted
@priyatharsan you can set your .credentials file to PythonPlotBot to save plots to that account.

@cldougl
Copy link
Member

cldougl commented Sep 5, 2018

@priyatharsan this is good to merge 💃 after running with PythonPlotBot

@cldougl cldougl removed the ReviewReady This PR is ready for review label Sep 5, 2018
@priyatharsan priyatharsan merged commit 599411e into source-design-merge Sep 5, 2018
@priyatharsan priyatharsan deleted the py-hist-custom-binning-doc-update branch September 5, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants