Add Dash Ads Inline #1079
Merged
Add Dash Ads Inline #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cldougl
reviewed
Sep 7, 2018
_includes/documentation_eg.html
Outdated
| @@ -717,7 +721,7 @@ <h4 class="example-section-title" id="layout-options"> | |||
| {% if databases %} | |||
| <section class="--tutorial-section no-image" id="databases"> | |||
| <header class="--section-header"><a href="#databases">Connecting to Databases</a> | |||
| <div class="icon copy" data-tooltip="Click to copy direct link."> | |||
| <div class="icon copy" data-tooltip="Click to copy direct lin k."> | |||
cldougl
reviewed
Sep 7, 2018
_includes/documentation_eg.html
Outdated
| @@ -627,6 +627,10 @@ <h4 class="example-section-title" id="layout-options"> | |||
| </div> | |||
| {% endif %} | |||
|
|
|||
| {% if page.language == "python" or page.language == "r" or page.language == "javascript" %} | |||
There was a problem hiding this comment.
this is working for me on /python and /r
for https://plot.ly/javascript the language is actually "plotly_js"
for example: https://github.com/plotly/documentation/pull/1079/files#diff-3c5b21462f63fc69d620c11747257935R501
|
I think this should be ready for review now. The ad is now visible on all 3 pages. |
|
💃 lgtm now! |
cldougl
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/plotly/streambed/issues/11340
The ad is showing on the Python page but not the JavaScript or R page.