Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Layout template examples. Demonstrate how Container arrays are handled #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

michaelbabyn
Copy link
Contributor

Resolves #1111 . The examples are centred around container arrays (defaults, name and templateitemname) and they also demonstrate creating templates with or without Plotly.makeTemplate.

cc @alexcjohnson

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Oct 19, 2018
@michaelbabyn michaelbabyn requested a review from cldougl October 19, 2018 15:03
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great. Quick 'watermark' style suggestion but otherwise this lgtm 💃

y: 0.85,
sizex: 0.7,
sizey: 0.7,
sizing: "stretch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelbabyn do you think this example might look a little better without the stretched image (maybe a little smaller/original proportions)

item in annotations will be used as the default.

Note, this behaviour works for all container array objects. E.g for `images`, you would create `imagedefaults` in
your layout containing the default image item.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 great description

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 29, 2018
@michaelbabyn michaelbabyn merged commit bc5d82f into source-design-merge Oct 29, 2018
@michaelbabyn michaelbabyn deleted the layout-template branch October 29, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants