Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Meta links fixed in matplotlib index page #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Meta links fixed in matplotlib index page #1179

wants to merge 4 commits into from

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Nov 19, 2018 •
edited
Loading

fixes #1177

inspecting the page and looking at the meta tag looks good to me - both links are clickable now

screen shot 2018-11-19 at 2 42 43 pm

ready for review cc. @cldougl

@Kully Kully requested a review from cldougl November 19, 2018 19:51
cldougl
cldougl reviewed Nov 20, 2018
View reviewed changes
@Kully
Copy link
Contributor Author

Kully commented Nov 27, 2018

@cldougl is this PR ready to go?

@priyatharsan
Copy link
Contributor

I removed the white spaces. Not sure if I understood the purpose of why they were added. But it looks good to me now 👍
cc @cldougl @Kully

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Jan 10, 2019
@priyatharsan priyatharsan mentioned this pull request Jan 25, 2019
Merged
@cldougl cldougl closed this Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldougl cldougl cldougl left review comments

Assignees
No one assigned
Labels
ReviewReady This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperlink quotes in post descriptions break meta tags
4 participants
@Kully @priyatharsan @cldougl @Coding-with-Adam