Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update maps docs with dict -> graph_objs #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2019
Merged

update maps docs with dict -> graph_objs #1271

merged 6 commits into from
Mar 5, 2019

Conversation

priyatharsan
Copy link
Contributor

@priyatharsan priyatharsan commented Mar 1, 2019 •
edited
Loading

@priyatharsan priyatharsan changed the title update bubble and choropleth maps with dict -> graph_objs update maps docs with dict -> graph_objs Mar 1, 2019
@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Mar 1, 2019
michaelbabyn
michaelbabyn reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to change the dict in geo=dict( to geo=go.layout.Geo( too (and everywhere else we use dict) to make our docs as consistent as possible.

@priyatharsan
Copy link
Contributor Author

@michaelbabyn I've removed all dicts and used as objects now.

@michaelbabyn
Copy link
Contributor

Thanks @priyatharsan . 💃

@michaelbabyn michaelbabyn removed the ReviewReady This PR is ready for review label Mar 4, 2019
@priyatharsan priyatharsan merged commit ecbe098 into source-design-merge Mar 5, 2019
@priyatharsan priyatharsan deleted the convert-to-graphobjs branch March 5, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbabyn michaelbabyn michaelbabyn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All docs should be using graphing objects (go)
2 participants
@priyatharsan @michaelbabyn