update navbar. currently the style is updated via main.css directly #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so the sccs will need to be updated as well to make this permanent.
|
The differences between this and the asks in #1355 are fine with me given the expected vs realized level of effort :) |
|
@cldougl I think you'll probably need to review this, as I worked on it a lot with Micheal so my review would be biased :P |
cldougl
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
This looks good - @michaelbabyn can you open an issue for:
The sccs will need to be updated as well to make this permanent.
then this is good to merge 💃
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sccs will need to be updated as well to make this permanent. Resolves #1355