Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Navbar scss #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

Navbar scss #1359

merged 2 commits into from
Jun 13, 2019

Conversation

michaelbabyn
Copy link
Contributor

resolves #1357.

@michaelbabyn michaelbabyn requested a review from cldougl June 13, 2019 16:41
@michaelbabyn
Copy link
Contributor Author

It was also easier in scss to update the button style to be more similar to the specs outlined in #1355:
scss-navbar

nicolaskruchten
nicolaskruchten approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@nicolaskruchten nicolaskruchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 love it!

@michaelbabyn michaelbabyn merged commit 7c40cfe into source-design-merge Jun 13, 2019
@michaelbabyn michaelbabyn deleted the navbar-scss branch June 13, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten nicolaskruchten approved these changes

@cldougl cldougl Awaiting requested review from cldougl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update sccs to make navbar changes from #1356 permanent
2 participants
@michaelbabyn @nicolaskruchten