Thanks to visit codestin.com
Credit goes to github.com

Skip to content

change redraw to true for choropleth map animation #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

michaelbabyn
Copy link
Contributor

resolves #1365

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Jun 21, 2019
@@ -1,6 +1,6 @@
---
name: Map Animations
plot_url: https://codepen.io/bcd/embed/rzrJjb/?height=500&theme-id=15263&default-tab=result
plot_url: https://codepen.io/plotly/embed/YoZLGQ/?height=500&theme-id=15263&default-tab=result
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelbabyn is this the correct codepen link? https://codepen.io/plotly/embed/YoZLGQ/?height=500&theme-id=15263&default-tab=result it doesn't seem to be animating to me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is. The data doesn't change very much year to year but you should notice that it works if you go from 2016 to 2010.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we could use different data that does visibly change to make this example a bit stronger? (even hovering on the data it didn't really look like the #s were changing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that would be a much better fix.

@michaelbabyn
Copy link
Contributor Author

I switched the dataset to gapminder here to increase the contrast in the animation and there was some other stuff wrong with this example that was preventing the hover from changing that is also fixed now.

cc @cldougl

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - thanks for updating the data @michaelbabyn !
💃

@cldougl cldougl removed the ReviewReady This PR is ready for review label Jun 26, 2019
@michaelbabyn michaelbabyn merged commit 30c2143 into source-design-merge Jun 26, 2019
@michaelbabyn michaelbabyn deleted the map-animation-fix branch June 26, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map animation not uploading
2 participants