-
-
Notifications
You must be signed in to change notification settings - Fork 544
change redraw to true for choropleth map animation #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,6 +1,6 @@ | |||
--- | |||
name: Map Animations | |||
plot_url: https://codepen.io/bcd/embed/rzrJjb/?height=500&theme-id=15263&default-tab=result | |||
plot_url: https://codepen.io/plotly/embed/YoZLGQ/?height=500&theme-id=15263&default-tab=result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelbabyn is this the correct codepen link? https://codepen.io/plotly/embed/YoZLGQ/?height=500&theme-id=15263&default-tab=result it doesn't seem to be animating to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is. The data doesn't change very much year to year but you should notice that it works if you go from 2016 to 2010.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we could use different data that does visibly change to make this example a bit stronger? (even hovering on the data it didn't really look like the #s were changing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that would be a much better fix.
frame generation logic.
I switched the dataset to gapminder here to increase the contrast in the animation and there was some other stuff wrong with this example that was preventing the hover from changing that is also fixed now. cc @cldougl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome - thanks for updating the data @michaelbabyn !
💃
resolves #1365