Adding a new ggplot page (geom_bin2d) #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and ran a test of the RMarkdown. Might edit some more, but it's more or less ready
| <iframe src="https://plot.ly/~RPlotBot/5674.embed" width="800" height="600" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe> | ||
|
|
||
| ### Customized Colours | ||
| The automatic colour scheme is unintuitive: lighter colours denote larger numbers than darker colours. |
There was a problem hiding this comment.
I'd like to stay away from self-criticism of the defaults if possible. I would just say "to change the colors..."
| <iframe src="https://plot.ly/~RPlotBot/5680.embed" width="800" height="600" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe> | ||
|
|
||
| ### With Facets | ||
| We can facet the graphic with the "region" column, and set "bins" to 20, so that the graph is 20 x 20 sides. We can also use a little trick to add an "All" subset containing all the data. |
There was a problem hiding this comment.
I'd remove the "little trick"... too fancy for docs IMO :) Or move it to a separate example.
There was a problem hiding this comment.
Can you remove the "little trick" reference from the text here too plz?
…+ one clarification made)
…bels so readers know what they're looking at
|
I've gone through your comments and updated this! I've also edited a confusing ggplot page I came across + reran the 11 R pages that were fine using plotly 4.9 |
|
One last little comment to address and then you can merge! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have proofed it locally!
(If you're wondering, there are eight commits because the first few were meant to test git on my first day - I then had to revert them once I realized that I was committing actual edits to this same branch.)