Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Waterfall funnel #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2019
Merged

Waterfall funnel #1442

merged 6 commits into from
Aug 13, 2019

Conversation

Mahdis-z
Copy link
Contributor

@Mahdis-z Mahdis-z commented Aug 6, 2019

No description provided.

thumbnail: thumbnail/funnel.jpg
language: plotly_js
page_type: example_index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got a lot of financial charts on the homepage now so I think we should create an index page like we have for some of the other sections so we only show five thumbnails from this section.

Personally, I'd like to keep candlestick, indicators, waterfalls, and funnels here and move the others to the index page.

@Mahdis-z Mahdis-z requested a review from michaelbabyn August 12, 2019 19:38
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Mahdis-z , 💃 once all the layout attributes are set to "user-guide" so that all the financial docs appear on the index page.

@@ -3,7 +3,7 @@
name: Indicators
permalink: javascript/indicator/
description: How to make a D3.js-based gauge chart in javascript.
layout: user-guide
layout: base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout attribute should be set to user-guide for all the docs in the financial section now so that they all appear in the index page. This is how it works for all the other index pages.

@Mahdis-z Mahdis-z merged commit 74a2956 into source-design-merge Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants