Update ref search #1462
Merged
Update ref search #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1461 by locking the algoliasearch version 1.20.0 (2.0 had some breaking changes that broke our scripts) and I added a check for traces that have layoutAttributes (e.g barmode) so they would be added too.
I also moved a change I made a while back in the .ipynb file into
update_ref_search.pywhich uses recursion to crawl the plot_schema to simplify things a bit (and make deep attributes like https://plot.ly/javascript/reference/#layout-xaxis-rangeselector-buttons-items-button-templateitemname work).