Thanks to visit codestin.com
Credit goes to github.com

Skip to content

circleci config #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 7, 2019
Merged

circleci config #1494

merged 8 commits into from
Sep 7, 2019

Conversation

Mahdis-z
Copy link
Contributor

@Mahdis-z Mahdis-z commented Sep 4, 2019

No description provided.

resource_class: xlarge
docker:
# a packaged system that has the instructions for creating a running container.
- image: circleci/ruby:2.4-node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 2.3.x, no node needed for now

- checkout

# Download and cache dependencies
- restore_cache:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

- run:
name: install dependencies
command: |
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a variation on gem install bundler && bundle install

sudo apt-get install -y poppler-utils libxtst6 xvfb libgtk2.0-0 libgconf-2-4 libnss3 libasound2

# Caches dependencies with a cache key
- save_cache:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

command: |
make -kj8 || make -kj8
if [ "${CIRCLE_BRANCH}" == "source-design-merge" ]; then
cd build/html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole block could just be rake deploy

@@ -29,5 +29,5 @@ jobs:
if [ "${CIRCLE_BRANCH}" == "source-design-merge" ]; then
rake deploy
else
bundle exec jekyll serve --config config_dev.yml
bundle exec jekyll serve --config _config_dev.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be jekyll build instead of jekyll serve (otherwise the command will not terminate) and you should not specify the dev config... for CI we want to use the default config :)

@Mahdis-z Mahdis-z merged commit 13c0705 into source-design-merge Sep 7, 2019
@Mahdis-z Mahdis-z deleted the circleCI branch September 7, 2019 13:36
@nicolaskruchten
Copy link
Contributor

Ah, it would have been good to wait for a dancer here to merge... I had a spare hour today so I finished up the config and added some caching and tuned some stuff so it all works now and takes under 3min to do a full build-and-deploy :)

@Mahdis-z
Copy link
Contributor Author

Mahdis-z commented Sep 8, 2019

Ah, it would have been good to wait for a dancer here to merge... I had a spare hour today so I finished up the config and added some caching and tuned some stuff so it all works now and takes under 3min to do a full build-and-deploy :)

Oops I thought we already agreed on it on Friday ... Btw, thanks for the revision 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants