-
-
Notifications
You must be signed in to change notification settings - Fork 544
circleci config #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circleci config #1494
Conversation
.circleci/config.yml
Outdated
resource_class: xlarge | ||
docker: | ||
# a packaged system that has the instructions for creating a running container. | ||
- image: circleci/ruby:2.4-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby 2.3.x, no node needed for now
.circleci/config.yml
Outdated
- checkout | ||
|
||
# Download and cache dependencies | ||
- restore_cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
.circleci/config.yml
Outdated
- run: | ||
name: install dependencies | ||
command: | | ||
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a variation on gem install bundler && bundle install
.circleci/config.yml
Outdated
sudo apt-get install -y poppler-utils libxtst6 xvfb libgtk2.0-0 libgconf-2-4 libnss3 libasound2 | ||
|
||
# Caches dependencies with a cache key | ||
- save_cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
.circleci/config.yml
Outdated
command: | | ||
make -kj8 || make -kj8 | ||
if [ "${CIRCLE_BRANCH}" == "source-design-merge" ]; then | ||
cd build/html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole block could just be rake deploy
.circleci/config.yml
Outdated
@@ -29,5 +29,5 @@ jobs: | |||
if [ "${CIRCLE_BRANCH}" == "source-design-merge" ]; then | |||
rake deploy | |||
else | |||
bundle exec jekyll serve --config config_dev.yml | |||
bundle exec jekyll serve --config _config_dev.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be jekyll build
instead of jekyll serve
(otherwise the command will not terminate) and you should not specify the dev config... for CI we want to use the default config :)
Ah, it would have been good to wait for a dancer here to merge... I had a spare hour today so I finished up the config and added some caching and tuned some stuff so it all works now and takes under 3min to do a full build-and-deploy :) |
Oops I thought we already agreed on it on Friday ... Btw, thanks for the revision 👍 |
No description provided.