insidetextorientation attribute in pie and sunburst #1659
Conversation
| --- | ||
| Plotly.d3.csv('https://raw.githubusercontent.com/plotly/datasets/master/coffee-flavors.csv', function(err, rows){ | ||
| function unpack(rows, key) { | ||
| return rows.map(function(row) {return row[key]}); |
There was a problem hiding this comment.
Semicolons are optional at the end of a javascript statement.
They are used in some lines here and are not used in other lines.
| ids: unpack(rows, 'ids'), | ||
| labels: unpack(rows, 'labels'), | ||
| parents: unpack(rows, 'parents'), | ||
| insidetextorientation: 'radial'}]; |
There was a problem hiding this comment.
I was wondering it might be easier to read if this is formatted like this:
var data = [{
type: "sunburst",
maxdepth: 2,
ids: unpack(rows, 'ids'),
labels: unpack(rows, 'labels'),
parents: unpack(rows, 'parents'),
insidetextorientation: 'radial'
}];|
|
||
| var layout = {margin: {l: 0, r: 0, b: 0, t:0}}; | ||
|
|
||
| Plotly.newPlot('myDiv', data, layout) |
There was a problem hiding this comment.
This line as well as some lines above may require indentation.
| type: "pie", | ||
| values: [2, 3, 4, 4], | ||
| labels: ["Wages", "Operating expenses", "Cost of sales", "Insurance"], | ||
| textinfo: "label+percent", |
There was a problem hiding this comment.
Let's add
textposition: "inside",here to ensure all the text fits inside.
There was a problem hiding this comment.
Hey Mahdis, this PR is looking really good. I just have a suggestion, which also applies to the sunburst doc in this PR.
I think that text could more explicitly describe these options.
Perhaps something like:
The insidetextorientation attribute controls the orientation of the text inside chart sectors. When set to 'auto', text may be oriented in any direction in order to be as big as possible in the middle of a sector. The 'horizontal' option orients text to be parallel with the bottom of the chart, and will make text smaller in order to achieve that goal. The 'radial' option orients text along the radius of the sector. The 'tangential' option orients text perpendicular to the radius of the sector.
What do you think?
Along with Mojtaba's comments, this looks ready to merge!
There was a problem hiding this comment.
Note that if you were to imagine your chart as a clock face, the 'horizontal', 'radial', and 'tangential' options first try to orient text at the the 3:00, 6:00, 9:00, and 12:00 hours. If that is not possible due to space constraints, then they position the text in the middle of the arc. On the other hand the auto option always shrinks text to fit in the middle of the arc.
|
Nicely done. |
No description provided.