Delete r/chart-studio files that are moving to r-docs #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I don't think these files should move to the r-docs repo... we don't want to run them on every commit, as they communicate with Chart Studio. |
|
Can you elaborate on why it would not be a good idea to run these files on every commit? Is it because charts would accumulate in the Chart Studio account that is linked to this repo? FYI, these files pass CI checks on the feature branch in the other repo. |
|
I just don't want to have these doc builds dependent on external services, and we've seen issues with updating/overwriting plots simultaneously on multiple concurrent CI runs in Python-land. |
|
This can be closed, right? |
|
Superseded by #1663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to delete files in the
r/chart-studiofolder which are being moved over toplotly.r-docs.