update modebar docs #1668
Merged
update modebar docs #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -0,0 +1,21 @@ | |||
| --- | |||
| name: Display Modebar | |||
There was a problem hiding this comment.
instead of "hide" and "display" the modebar can we find some way of saying "Disable modebar" and "Force modebar to be always visible" with an explanation of the default behaviour and what this override does?
I say this because the modebar already does "hide" and "display" by default, so just saying "hide" and "display" isn't quite clear enough.
There was a problem hiding this comment.
We could also just restore the old title with the "always" for now and fix it later :)
|
💃 once we address the "always" comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is twofold:
First, to update some of the language around modebar configuration to make more explicit what options users have to add or remove icons.
Second, to bring this doc page in line with other pages in terms of having example figures generated inline rather than using embedded codepens.
plot_urlfront-matter to inline chartThanks @Mahdis-z for pointing this out!