Andrew obliterate and redo #39
Conversation
Note that canadien cities didn't work for some reason: https://plot.ly/~TestBot/386
|
@mkcor, @xsaintmleux, i mentioned in the ggplotly HC room, but this graph isn't working: https://plot.ly/~TestBot/386 It was made from this code: library(plotly)
py <- plotly(username='TestBot', key='r1neazxo9w')
data(canada.cities, package="maps")
viz <- ggplot(canada.cities, aes(long, lat)) +
borders(regions="canada", name="borders") +
coord_equal() +
geom_point(aes(text=name, size=pop), colour="red", alpha=1/2, name="cities")
out <- py$ggplotly(viz)
plotly_url <- out$response$urlAny thoughts? |
the convention was set as this: `p <- plotly(...)` for r, but was changed to this: `py <-plotly(...)` streambed translator doesn't reflect this yet, so we need to put a line to catch the older version of this sign-in.
|
@chriddyp , @alexander-daniel , @BRONSOLO , @mkcor , @etpinard , Here's a fresh version of auto-docs. Should fix a lot of the (1) formatting stuff that's come up and (2) missing links. Note, this has not been run with PlotBot, just TestBot. I'd like to merge this in to master, update it with the changes in the shiny branch and then create a final branch that will be totally up-to-date and merge that in. I clicked around and didn't notice anything that was alarming. That said, there are a lot of examples in here... |
| plotly.plot(data, graph_options, function (err, msg) { | ||
| console.log(msg); | ||
| }); |
There was a problem hiding this comment.
hm... i don't think this are right. /js/ is for the javascript graphing library which has a different call signature than the node.js examples. the previous version of this example looked correct
Before, run.py was formatting all of the sign-in lines and plot-calls. Now, these things happen in the code_translator. Therefore, we need to actually insert lines into the code we get back for the initializations to happen in a reasonable order.
|
@chriddyp , alright, i'm pretty sure i fixed up all the issues you pointed out. The only one remaining is the Plotly.js stuff. We can just do some fancy git-footwork to keep the old files in streambed after we copy things over. Thanks for going over those files!! |
|
@chriddyp , @etpinard , @mkcor , sorry to bug you guys, but I'd like to get this passed off so that i can merge in the shiny stuff, and then we can really be up-to-date on api docs. @chriddyp , also, the file-options still aren't sorted in any way. i'll make a PR for the code_translator on that today, but i don't think it's worth waiting here for since i'll rerun this all after shiny stuff is included anyways. |
| response <- p$plotly(data, kwargs=list(fileopt="overwrite", filename="basic-bar")) |
There was a problem hiding this comment.
@theengineear I think this should be py$plotly
There was a problem hiding this comment.
ah, yup, nice catch! this is also a code translator thing, the convention got changed at some point and it just needs to get updated.
|
Othewise, 👍 |
| response <- p$plotly(data, kwargs=list(layout=layout, fileopt="overwrite", filename="stacked-bar")) |
There was a problem hiding this comment.
p should be py to be consistent with change above.
Just shallow copy the dict instead and things are OK.
Andrew obliterate and redo
Much cleaner redo, started from scratch to make sure all these urls are up to date. Still need to run the matlab scripts.