-
-
Notifications
You must be signed in to change notification settings - Fork 544
Andrew merge in shiny #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexander-daniel , @mkcor -> shiny! So close! |
@@ -0,0 +1,2 @@ | |||
|
|||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worries me, let me look into this one. These are just place-holders, but I think this should be filled out either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, obviously we wouldn't know how to translate into ggplot2! It's a separate library. Normally ggplot2 examples are scripts, but we are just using a placeholder model (json) example. This is OK.
Alright, added newlines everywhere (and fixed newlines for scripts). This literally changes every file, so it won't be fun to look at without the "?w=1" query at the end of the URL: |
We have |
haha, oh @alexander-daniel (i think?). nope, doesn't matter at all. None of that text actually end up on the site. |
+1 to sync up with the website |
@mkcor . Thanks!! I'll run a publish.py publish on it, pull this in an then make a streambed PR. |
Merging in shiny stuff that couldn't wait for this overhaul get onto prod.