Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Andrew merge in shiny #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 19, 2014
Merged

Andrew merge in shiny #43

merged 7 commits into from
Sep 19, 2014

Conversation

theengineear
Copy link
Contributor

Merging in shiny stuff that couldn't wait for this overhaul get onto prod.

@theengineear
Copy link
Contributor Author

@alexander-daniel , @mkcor -> shiny!

So close!

@@ -0,0 +1,2 @@

{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worries me, let me look into this one. These are just place-holders, but I think this should be filled out either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, obviously we wouldn't know how to translate into ggplot2! It's a separate library. Normally ggplot2 examples are scripts, but we are just using a placeholder model (json) example. This is OK.

@theengineear
Copy link
Contributor Author

Alright, added newlines everywhere (and fixed newlines for scripts). This literally changes every file, so it won't be fun to look at without the "?w=1" query at the end of the URL:
https://github.com/plotly/documentation/pull/43/files?w=1

@mkcor
Copy link
Contributor

mkcor commented Sep 19, 2014

We have exlusive-embedding and iframes-exlusive in our path names... I guess we meant exclusive. @theengineear Does it matter?

@theengineear
Copy link
Contributor Author

haha, oh @alexander-daniel (i think?). nope, doesn't matter at all. None of that text actually end up on the site.

@mkcor
Copy link
Contributor

mkcor commented Sep 19, 2014

+1 to sync up with the website

@theengineear
Copy link
Contributor Author

@mkcor . Thanks!! I'll run a publish.py publish on it, pull this in an then make a streambed PR.

theengineear added a commit that referenced this pull request Sep 19, 2014
@theengineear theengineear merged commit 6e49f54 into master Sep 19, 2014
@theengineear theengineear deleted the andrew-merge-in-shiny branch September 19, 2014 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants