update search ux/ui [ready for review] #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 20, 2020 15:07
|
Screenshots:
|
_includes/layouts/_header-main.html
Outdated
| @@ -9,6 +9,13 @@ | |||
| <div class="--wrap-right"> | |||
| <nav class="--nav-meta" role="navigation"> | |||
| <ul> | |||
| {% unless page.permalink == "/api/" %} | |||
There was a problem hiding this comment.
this should probably only be on the 4 target languages right? not e.g. MATLAB or Julia etc
There was a problem hiding this comment.
Changed the conditional to target correct set of pages.
|
|
||
| var emptyResult = '<div class="text-center"><br><br>No results found matching <strong>{{query}}</strong>.<br><br> Click here to <a class="algolia__result-link" target="_blank" href="https://www.google.com/search?q=site%3Aplot.ly+{{query}}">search for "plotly ' + lang + ' {{query}}" on Google</a>.</div>'; |
There was a problem hiding this comment.
need to fix the search query to match what it says in quotes :)
There was a problem hiding this comment.
fixed query to match text.
…ary-docs into algolia-start-fresh
added 16 commits
March 9, 2020 16:19
|
@nicolaskruchten This PR is ready for review. |
all_static/css/main.css
Outdated
|
|
||
| .modal > .modal-dialog{ | ||
| width: 1050px; | ||
| height: 700px; |
There was a problem hiding this comment.
let's get rid of this line here, which is adding an unnecessary scrollbar.
|
Last two CSS changes then merge! 💃 |
Co-Authored-By: Nicolas Kruchten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7
Work plan: