Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docker: pin Inkscape's version and enable all EMF fixes #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

antoinerg
Copy link
Collaborator

Closes #218 by enabling all EMF fixes available in Inkscape.

@etpinard
Copy link
Contributor

Wow. Great fix! πŸ’ƒ

@antoinerg
Copy link
Collaborator Author

For future reference, the following gist contains a script that docker pull, run and produce a EMF figure using the Docker image built from commit cb9c1e4:

git clone https://gist.github.com/272c1cbf8db24e4c2aceffc91d137bf7.git
cd 272c1cbf8db24e4c2aceffc91d137bf7
./render.sh

Then inspect the resulting fig.emf or fig.emf.png. We see that the colorbar renders properly:
fig emf

The above test should be automated and part of our test suite whenever we add image tests to Orca πŸŽ‰

@antoinerg antoinerg merged commit d735199 into 3.1-release Mar 26, 2019
@antoinerg antoinerg deleted the 3.1-fix-emf branch March 26, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants