Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Consistent container update / removal #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2016
Merged

Consistent container update / removal #1086

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
133bf1a
plots: expose list of data / layout array containers
etpinard Oct 26, 2016
e2524ea
add api helpers for managing array container updates
etpinard Oct 26, 2016
66c3ca0
restyle: call manageArrayContainers on array-container updates
etpinard Oct 26, 2016
2cafbeb
relayout: merge all array container update logic into 1 block
etpinard Oct 26, 2016
010c792
relayout: add support for calls with `null` for annotation / shape
etpinard Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
plots: expose list of data / layout array containers 
- to be used in relayout / restyle
  • Loading branch information
@etpinard
etpinard committed Oct 26, 2016
commit 133bf1af1ee38e42f82097f790c5c01d981c5b39
13 changes: 5 additions & 8 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,6 +1424,9 @@ plots.extendObjectWithContainers = function(dest, src, containerPaths) {
return dest;
};

plots.dataArrayContainers = ['transforms'];
plots.layoutArrayContainers = ['annotations', 'shapes', 'images', 'sliders', 'updatemenus'];

/*
* Extend a trace definition. This method:
*
Expand All @@ -1433,7 +1436,7 @@ plots.extendObjectWithContainers = function(dest, src, containerPaths) {
* The result is the original object reference with the new contents merged in.
*/
plots.extendTrace = function(destTrace, srcTrace) {
return plots.extendObjectWithContainers(destTrace, srcTrace, ['transforms']);
return plots.extendObjectWithContainers(destTrace, srcTrace, plots.dataArrayContainers);
};

/*
Expand All @@ -1446,13 +1449,7 @@ plots.extendTrace = function(destTrace, srcTrace) {
* The result is the original object reference with the new contents merged in.
*/
plots.extendLayout = function(destLayout, srcLayout) {
return plots.extendObjectWithContainers(destLayout, srcLayout, [
'annotations',
'shapes',
'images',
'sliders',
'updatemenus'
]);
return plots.extendObjectWithContainers(destLayout, srcLayout, plots.layoutArrayContainers);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Nice refactor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I thought exposing plots.layoutArrayContainers was a nice compromise.

Next step would be to auto-generate that list using the plot-schema. (later ...)

};

/**
Expand Down